Skip to content

Make DialogTrigger use screen width to determine if mobile or not#3921

Merged
LFDanLu merged 2 commits intomainfrom
issue_3905
Jan 17, 2023
Merged

Make DialogTrigger use screen width to determine if mobile or not#3921
LFDanLu merged 2 commits intomainfrom
issue_3905

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jan 14, 2023

Closes #3905

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the DialogTrigger and DatePicker/RangePicker stories. They should now render their defined mobileType/trays only when the screen width of your device is less than 700px rather than if the window width is less than 700px

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jan 14, 2023

@LFDanLu LFDanLu changed the title (WIP) Make DialogTrigger use screen width to determine if mobile or not Make DialogTrigger use screen width to determine if mobile or not Jan 17, 2023
@rspbot
Copy link

rspbot commented Jan 17, 2023

@rspbot
Copy link

rspbot commented Jan 17, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LFDanLu LFDanLu merged commit d524547 into main Jan 17, 2023
@LFDanLu LFDanLu deleted the issue_3905 branch January 17, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog Trigger should correctly determine mobile device

4 participants